Skip to content

ravenna-alsa-lkm-bondagit: init at unstable-2023-07-16#246268

Draft
mrobbetts wants to merge 2 commits intoNixOS:masterfrom
mrobbetts:ravenna-alsa-lkm-bondagit
Draft

ravenna-alsa-lkm-bondagit: init at unstable-2023-07-16#246268
mrobbetts wants to merge 2 commits intoNixOS:masterfrom
mrobbetts:ravenna-alsa-lkm-bondagit

Conversation

@mrobbetts
Copy link
Copy Markdown
Contributor

@mrobbetts mrobbetts commented Jul 30, 2023

Description of changes

Init the (customized) Merging Technologies Ravenna ALSA kernel module from https://github.com/bondagit/ravenna-alsa-lkm/

This module provides AES67 capability, (alongside a user-space control process, such as the aes67-daemon project, for which a NixOS PR will follow).

I have this running on my x86-64 linux system, enabled via:

boot.extraModulePackages = [ config.boot.kernelPackages.ravenna-alsa-lkm-bondagit ];

and auto-loaded with:

boot.kernelModules = [ ... "MergingRavennaALSA" ];

One question I have is, the upstream documentation notes that this module requires a kernel with:

NETFILTER
HIGH_RES_TIMERS
NETLINK

options enabled, but I couldn't figure out a way to define such a requirement from inside the driver's module package. One thought is, this driver is only really going to be pulled in as a dependency of the aes67-daemon package, for which I have a NixOS module, and these requirements can be encoded there. Is this the standard approach?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from 4e1d30f to bec1655 Compare July 30, 2023 23:36
@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 31, 2023
@mrobbetts
Copy link
Copy Markdown
Contributor Author

(gentle bump)

@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from bec1655 to 0ab0db9 Compare September 14, 2023 19:59
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch 2 times, most recently from 6f00c61 to 09130c0 Compare October 11, 2023 01:03
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from 09130c0 to 28b8292 Compare November 28, 2023 01:20
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from 28b8292 to 738e811 Compare June 16, 2024 21:20
@github-actions github-actions Bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 16, 2024
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch 2 times, most recently from 29bfb04 to db6db1f Compare July 4, 2024 06:10
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from db6db1f to d72b5e8 Compare July 27, 2024 06:27
@@ -0,0 +1,43 @@
{ lib
, stdenv
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format with the new formatter.

'';

meta = {
description = "Merging Technologies' ALSA driver implementation of Ravenna and AES67, with additional work by bondagit";
Copy link
Copy Markdown
Member

@FliegendeWurst FliegendeWurst Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Merging Technologies' ALSA driver implementation of Ravenna and AES67, with additional work by bondagit";
description = "Technologies' ALSA driver implementation of Ravenna and AES67";

meta = {
description = "Merging Technologies' ALSA driver implementation of Ravenna and AES67, with additional work by bondagit";
homepage = "https://github.com/bondagit/ravenna-alsa-lkm";
license = lib.licenses.gpl3;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPLv3 is odd for a kernel module. Are you sure it is correct?

@FliegendeWurst FliegendeWurst marked this pull request as draft January 17, 2025 16:30
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch 2 times, most recently from 606c1b1 to 5e69655 Compare March 8, 2025 02:57
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from 0be6985 to 7521a85 Compare April 21, 2025 15:43
@ofborg ofborg Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 21, 2025
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from 7521a85 to 964c8c7 Compare April 21, 2025 15:55
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from 964c8c7 to 0553a5f Compare May 7, 2025 05:30
@nixpkgs-ci nixpkgs-ci Bot removed the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Oct 19, 2025
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch 2 times, most recently from d05f549 to be2c370 Compare October 19, 2025 06:19
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from be2c370 to 8a3a6fc Compare January 20, 2026 00:37
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version and removed 8.has: package (update) This PR updates a package to a newer version labels Jan 25, 2026
@mrobbetts mrobbetts force-pushed the ravenna-alsa-lkm-bondagit branch from 8a3a6fc to f45d5f7 Compare March 14, 2026 22:12
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants