ravenna-alsa-lkm-bondagit: init at unstable-2023-07-16#246268
Draft
mrobbetts wants to merge 2 commits intoNixOS:masterfrom
Draft
ravenna-alsa-lkm-bondagit: init at unstable-2023-07-16#246268mrobbetts wants to merge 2 commits intoNixOS:masterfrom
mrobbetts wants to merge 2 commits intoNixOS:masterfrom
Conversation
4e1d30f to
bec1655
Compare
Contributor
Author
|
(gentle bump) |
bec1655 to
0ab0db9
Compare
6f00c61 to
09130c0
Compare
09130c0 to
28b8292
Compare
28b8292 to
738e811
Compare
29bfb04 to
db6db1f
Compare
db6db1f to
d72b5e8
Compare
| @@ -0,0 +1,43 @@ | |||
| { lib | |||
| , stdenv | |||
Member
There was a problem hiding this comment.
Please format with the new formatter.
| ''; | ||
|
|
||
| meta = { | ||
| description = "Merging Technologies' ALSA driver implementation of Ravenna and AES67, with additional work by bondagit"; |
Member
There was a problem hiding this comment.
Suggested change
| description = "Merging Technologies' ALSA driver implementation of Ravenna and AES67, with additional work by bondagit"; | |
| description = "Technologies' ALSA driver implementation of Ravenna and AES67"; |
| meta = { | ||
| description = "Merging Technologies' ALSA driver implementation of Ravenna and AES67, with additional work by bondagit"; | ||
| homepage = "https://github.com/bondagit/ravenna-alsa-lkm"; | ||
| license = lib.licenses.gpl3; |
Member
There was a problem hiding this comment.
GPLv3 is odd for a kernel module. Are you sure it is correct?
606c1b1 to
5e69655
Compare
0be6985 to
7521a85
Compare
7521a85 to
964c8c7
Compare
964c8c7 to
0553a5f
Compare
d05f549 to
be2c370
Compare
be2c370 to
8a3a6fc
Compare
8a3a6fc to
f45d5f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Init the (customized) Merging Technologies Ravenna ALSA kernel module from https://github.com/bondagit/ravenna-alsa-lkm/
This module provides AES67 capability, (alongside a user-space control process, such as the aes67-daemon project, for which a NixOS PR will follow).
I have this running on my x86-64 linux system, enabled via:
and auto-loaded with:
One question I have is, the upstream documentation notes that this module requires a kernel with:
options enabled, but I couldn't figure out a way to define such a requirement from inside the driver's module package. One thought is, this driver is only really going to be pulled in as a dependency of the aes67-daemon package, for which I have a NixOS module, and these requirements can be encoded there. Is this the standard approach?
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)