nixos/libvirtd: Use preferred version of iptables#228625
Merged
FliegendeWurst merged 1 commit intoNixOS:masterfrom May 10, 2025
Merged
nixos/libvirtd: Use preferred version of iptables#228625FliegendeWurst merged 1 commit intoNixOS:masterfrom
FliegendeWurst merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
Bot
added
6.topic: nixos
ofborg
Bot
added
10.rebuild-darwin: 0
tomfitzhenry
approved these changes
Sep 21, 2023
Contributor
tomfitzhenry
left a comment
tomfitzhenry
left a comment
There was a problem hiding this comment.
LGTM. nixosTests.libvirtd passes.
wegank
added
the
2.status: stale
FliegendeWurst
approved these changes
Dec 1, 2024
stale
Bot
removed
the
2.status: stale
wegank
added
12.approvals: 2
wegank
added
the
2.status: stale
wegank
added
the
2.status: merge conflict
zhaofengli
force-pushed
the
libvirtd-preferred-iptables
branch
from
0bbc4d5 to
88fc736
Compare
ofborg
Bot
removed
the
2.status: merge conflict
stale
Bot
removed
2.status: stale
zhaofengli
force-pushed
the
libvirtd-preferred-iptables
branch
from
88fc736 to
13bb852
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Similar to #181334. Currently, if you set
networking.firewall.package = pkgs.iptables-legacy;and enable libvirtd at the same time, the system path will contain the nft-based iptables.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)