Account for tagging the root volume after spot loss#102
Open
tewfik-ghariani wants to merge 3 commits intoNixOS:masterfrom
Open
Account for tagging the root volume after spot loss#102tewfik-ghariani wants to merge 3 commits intoNixOS:masterfrom
tewfik-ghariani wants to merge 3 commits intoNixOS:masterfrom
Conversation
Once a spot instance is lost or a spot request in cancelled, the root volume re- created is not appended to the block device mapping because the 'first_boot' was set to False. With this update, we are sure that all mapped volumes are consist ently tagged Other - Tag using root vol Name as depl name instead of description - Deletion of the condition to tag the volumes - Use of generic 'update_tags' method - Removal of first_boot ec2 attribute
tewfik-ghariani
commented
May 6, 2020
| for device_stored, v in self.block_device_mapping.items(): | ||
| device_real = device_name_stored_to_real(device_stored) | ||
|
|
||
| if not ( |
Contributor
Author
There was a problem hiding this comment.
This has been reverted per 4584924
Thanks @PsyanticY for the call-out
Contributor
Author
|
Well I'm second thinking this after reading the reason behind 'first_boot' : NixOS/nixops@ee60f04 cc @AmineChikhaoui Do you think that would break something and that I should follow a different approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once a spot instance is lost or a spot request in cancelled, the root volume re-created is not appended to the block device mapping because the 'first_boot' was set to False. With this update, we are sure that all mapped volumes are consistently tagged
Other
Note: The branch is based on #101 so the changes can be confusing. You can view them in this single commit : 3fcecd4