Skip to content

Change attributes in RequestInfoImpl to be a ConcurrentHashMap#148

Merged
nicmunroe merged 2 commits into
Nike-Inc:mainfrom
jrduncans:concurrent-request-attributes
Apr 21, 2025
Merged

Change attributes in RequestInfoImpl to be a ConcurrentHashMap#148
nicmunroe merged 2 commits into
Nike-Inc:mainfrom
jrduncans:concurrent-request-attributes

Conversation

@jrduncans
Copy link
Copy Markdown
Member

Fix a potential problem where an attribute added from one thread and then accessed afterwards from another thread may not be visible by using ConcurrentHashMap.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (14167df) to head (1c81b69).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #148      +/-   ##
============================================
- Coverage     92.39%   92.37%   -0.03%     
  Complexity     2515     2515              
============================================
  Files           167      167              
  Lines          7274     7274              
  Branches        986      986              
============================================
- Hits           6721     6719       -2     
  Misses          363      363              
- Partials        190      192       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nicmunroe nicmunroe merged commit 8afe722 into Nike-Inc:main Apr 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants