Added support for style and constituents per aggregate#645
Open
DhivyaBharathi215 wants to merge 1 commit intointegration/mainfrom
Open
Added support for style and constituents per aggregate#645DhivyaBharathi215 wants to merge 1 commit intointegration/mainfrom
DhivyaBharathi215 wants to merge 1 commit intointegration/mainfrom
Conversation
Signed-off-by: bdhivya <[email protected]>
DhivyaBharathi215
requested review from
carchi8py,
chuyich,
suhasbshekar and
wenjun666
as code owners
chuyich
reviewed
Apr 4, 2026
| data.Style = types.StringValue(response.Style) | ||
| if data.ConstituentsPerAggregate.IsUnknown() { | ||
| data.ConstituentsPerAggregate = types.Int64Null() | ||
| } |
Contributor
There was a problem hiding this comment.
IsUnknown vs IsNull.
sometime check both, but sometime just check one. Maybe it's better to be consistent.
chuyich
reviewed
Apr 4, 2026
Contributor
chuyich
left a comment
chuyich
left a comment
There was a problem hiding this comment.
Some questions need your input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for style and constituents per aggregate