Set owner (SVM) when importing security_account resource#460
Merged
suhasbshekar merged 3 commits intoNetApp:release-2.2from Apr 8, 2025
Merged
Set owner (SVM) when importing security_account resource#460suhasbshekar merged 3 commits intoNetApp:release-2.2from
owner (SVM) when importing security_account resource#460suhasbshekar merged 3 commits intoNetApp:release-2.2from
Conversation
acch
requested review from
carchi8py,
chuyich,
suhasbshekar and
wenjun666
as code owners
Contributor
|
Please rebase here as well to get latest changes to github actions. |
Signed-off-by: Achim Christ <achim.christ@sva.de>
Signed-off-by: Achim Christ <achim.christ@sva.de>
acch
force-pushed
the
457-import-security_account
branch
from
9b037ba to
5f1916f
Compare
Contributor
Author
|
Thanks for your review @suhasbshekar - I've rebased to Please let me know what's missing. |
Signed-off-by: Achim Christ <achim.christ@sva.de>
acch
force-pushed
the
457-import-security_account
branch
from
87a74b1 to
f5bd7e6
Compare
suhasbshekar
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes error importing
security_accountresource if same account exists on multiple SVMsCloses #457.
Acceptance tests pass:
$ TF_ACC=1 go test ./internal/provider/security/security_account_resource_test.go -v === RUN TestAccSecurityAccountResource --- PASS: TestAccSecurityAccountResource (2.30s) PASS ok command-line-arguments 2.314s$ TF_ACC=1 go test ./internal/provider/security/security_account_resource_alias_test.go -v === RUN TestAccSecurityAccountResourceAlias --- PASS: TestAccSecurityAccountResourceAlias (2.28s) PASS ok command-line-arguments 2.291s