Skip to content

367 bug advertised kdc encryptions tf provider unexpectedly returned no resource state after having no errors in the resource creation #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suhasbshekar merged 4 commits into from
Apr 2, 2025
+4 −2
Merged

367 bug advertised kdc encryptions tf provider unexpectedly returned no resource state after having no errors in the resource creation #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a9d8b8
Modified version check condition for kdc_encryption
DhivyaBharathi215 Mar 11, 2025
2f7b845
Changelog added
DhivyaBharathi215 Mar 11, 2025
5439dd7
Idempotency issue fix
DhivyaBharathi215 Mar 12, 2025
9b4ff07
resolved conflicts
suhasbshekar Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ BUG FIXES:
- **netapp-ontap_security_account**: fixed inconsistency plan changes when re-run with terraform apply ([#465](https://github.com/NetApp/terraform-provider-netapp-ontap/issues/465))
- Corrected Resource and Data Source documentation Names ([#441](https://github.com/NetApp/terraform-provider-netapp-ontap/issues/441))
- **netapp-ontap_svm_qos_policy_activation**: Renamed documentation from `svm_qos_policy_activation_resource` to `svm_qos_policy_activation` ([#430](https://github.com/NetApp/terraform-provider-netapp-ontap/issues/430))
- **netapp-ontap_cifs_service**: Fixed no resource state after creation by modifying the "kdc_encrytion" version check and also idempotency issue with CIFS server name([#367](https://github.com/NetApp/terraform-provider-netapp-ontap/issues/367))

# 2.1.1 (2025-02-26)

Expand Down
1 change: 1 addition & 0 deletions internal/interfaces/protocols_cifs_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ func GetCifsServiceByName(errorHandler *utils.ErrorHandler, r restclient.RestCli
return nil, errorHandler.MakeAndReportError(fmt.Sprintf("failed to decode response from GET %s", api),
fmt.Sprintf("error: %s, statusCode %d, response %#v", err, statusCode, response))
}
dataONTAP.Name = name
tflog.Debug(errorHandler.Ctx, fmt.Sprintf("Read protocols_cifs_service data source: %#v", dataONTAP))
return &dataONTAP, nil
}
Expand Down
4 changes: 2 additions & 2 deletions internal/provider/protocols/protocols_cifs_service_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ func (r *CifsServiceResource) Read(ctx context.Context, req resource.ReadRequest
errorHandler.MakeAndReportError("No CIFS service found", fmt.Sprintf("CIFS service %s not found.", data.Name.ValueString()))
return
}
data.Name = types.StringValue(strings.ToLower(restInfo.Name))
data.Name = types.StringValue(restInfo.Name)
data.SVMName = types.StringValue(restInfo.SVM.Name)
if len(restInfo.Comment) != 0 {
data.Comment = types.StringValue(restInfo.Comment)
Expand Down Expand Up @@ -581,7 +581,7 @@ func (r *CifsServiceResource) Create(ctx context.Context, req resource.CreateReq
body.Security.SmbSigning = security.SmbSigning.ValueBool()
body.Security.SmbEncryption = security.SmbEncryption.ValueBool()
// kdc_encryption is only supported in 9.12 and earlier
if !security.KdcEncryption.IsNull() {
if !security.KdcEncryption.IsNull() && security.KdcEncryption.ValueBool() {
if cluster.Version.Generation == 9 && cluster.Version.Major < 12 {
body.Security.KdcEncryption = security.KdcEncryption.ValueBool()
} else {
Expand Down
Loading