245 - enhancement - netapp-ontap_volume resource#425
Closed
csahu9 wants to merge 7 commits intorelease-2.2from
Closed
245 - enhancement - netapp-ontap_volume resource#425csahu9 wants to merge 7 commits intorelease-2.2from
csahu9 wants to merge 7 commits intorelease-2.2from
Conversation
csahu9
requested review from
carchi8py,
chuyich,
suhasbshekar and
wenjun666
as code owners
carchi8py
requested changes
Mar 19, 2025
Collaborator
carchi8py
left a comment
carchi8py
left a comment
There was a problem hiding this comment.
make sure to add any new variable to the data source as well.
And the the examples.
carchi8py
approved these changes
Mar 27, 2025
Contributor
|
please resolve conflicts |
suhasbshekar
requested changes
Apr 3, 2025
| if err := mapstructure.Decode(response, &dataONTAP); err != nil { | ||
| return nil, errorHandler.MakeAndReportError("error decoding volume info by name", fmt.Sprintf("error on decode storage/volumes: %s, statusCode %d, response %#v", err, statusCode, response)) | ||
| } | ||
| if dataONTAP.Efficiency.Policy.Name == "" || dataONTAP.Efficiency.Policy.Name == "-" { |
csahu9
force-pushed
the
245-enhancement-netapp-ontap_volume_resource
branch
from
bac79a3 to
112cee0
Compare
Contributor
Author
|
Recreating this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #245
autosize.*to volume resource