Skip to content

remove prolog from demo page#776

Merged
amitguptagwl merged 1 commit into
NaturalIntelligence:masterfrom
ulrichstark:remove-prolog-from-demo-page
Jun 3, 2026
Merged

remove prolog from demo page#776
amitguptagwl merged 1 commit into
NaturalIntelligence:masterfrom
ulrichstark:remove-prolog-from-demo-page

Conversation

@ulrichstark
Copy link
Copy Markdown
Contributor

Purpose / Goal

Closes #774

Type

Please mention the type of PR

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend [WIP] in PR title. Your PR will be reviewed when [WIP] will be removed from the PR title.

Bookmark this repository for further updates.

@amitguptagwl
Copy link
Copy Markdown
Member

Thanks for your PR. But can you please make it conditional? so if it is not present then let it be added as before.

@ulrichstark
Copy link
Copy Markdown
Contributor Author

Thanks for your PR. But can you please make it conditional? so if it is not present then let it be added as before.

Thanks for your review! While working on your requested change, I noticed that there might be more to that issue: #774 (comment)

@ulrichstark
Copy link
Copy Markdown
Contributor Author

Superseded by #836

@ulrichstark ulrichstark closed this Jun 2, 2026
@amitguptagwl
Copy link
Copy Markdown
Member

I didn't understand your concern

@ulrichstark
Copy link
Copy Markdown
Contributor Author

I didn't understand your concern

You merged PR #836, which is declared to fix the same issue as this PR. That's why I closed this PR.
Or did I understand something wrong?

@ulrichstark ulrichstark reopened this Jun 2, 2026
@amitguptagwl amitguptagwl merged commit be6e9d9 into NaturalIntelligence:master Jun 3, 2026
3 checks passed
@ulrichstark ulrichstark deleted the remove-prolog-from-demo-page branch June 3, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XML prolog is included as "?xml" property in json output

2 participants