WindowManager Array Transition (part 1) by amirroth · Pull Request #11432 · NatLabRockies/EnergyPlus

amirroth · 2026-02-25T01:10:13Z

Pull request overview

This is a refactor that moves some arrays in WindowManager from Array1D<> and Array2D<> to std::array<> and std::array<std::array<>>, transitions 1-based loops and indexing to 0-based loops and indexing, and moves some variables from state to local scope. Completing the array transition will probably take one more PR.

There are no diffs.

github-actions · 2026-02-25T01:44:51Z

⚠️ Regressions detected on ubuntu-24.04 for commit `c7dc965`

Regression Summary

EIO: 3
ESO Small Diffs: 1
MTR Small Diffs: 1
Table Small Diffs: 1
ESO Big Diffs: 2
Table Big Diffs: 2

github-actions · 2026-02-25T01:45:53Z

⚠️ Regressions detected on macos-14 for commit `c7dc965`

Regression Summary

EIO: 3
ESO Small Diffs: 1
MTR Small Diffs: 1
Table Small Diffs: 1
ESO Big Diffs: 2
Table Big Diffs: 2

github-actions · 2026-02-25T14:13:27Z

⚠️ Regressions detected on ubuntu-24.04 for commit `1f95993`

Regression Summary

EIO: 3
ESO Small Diffs: 1
MTR Small Diffs: 1
Table Small Diffs: 1
ESO Big Diffs: 2
Table Big Diffs: 2

github-actions · 2026-02-25T14:18:21Z

⚠️ Regressions detected on macos-14 for commit `1f95993`

Regression Summary

EIO: 3
ESO Small Diffs: 1
MTR Small Diffs: 1
Table Small Diffs: 1
ESO Big Diffs: 2
Table Big Diffs: 2

rraustad · 2026-02-25T17:52:25Z

-        rbt = wm->rbop[0][n - 1];
+        tt = top[n - 1][0];
+        rft = rfop[n - 1][0];
+        rbt = rbop[0][n - 1];


Looking a the issue you found using bisect just above here (1944), why wasn't the index of top, rfop, and rbop also changed here (1951 - 1953)?

I found it.

github-actions · 2026-02-25T18:11:19Z

⚠️ Regressions detected on macos-14 for commit `dc0cc45`

Regression Summary

EIO: 2
ESO Big Diffs: 2
Table Big Diffs: 2

github-actions · 2026-02-25T20:29:52Z

⚠️ Regressions detected on macos-14 for commit `28a4e4a`

Regression Summary

EIO: 353
ERR: 82
ESO Big Diffs: 332
Table Big Diffs: 341
Table String Diffs: 309
MTR Big Diffs: 258
SSZ Big Diffs: 225
ZSZ Big Diffs: 247
MAP: 4
JSON Big Diffs: 1
Audit: 2
ESO Small Diffs: 9
DELightIn: 1
DELightOut: 1
EDD: 6
MTR Small Diffs: 21
PERF_LOG: 1

github-actions · 2026-02-25T21:33:04Z

⚠️ Regressions detected on macos-14 for commit `467bc0a`

Regression Summary

EIO: 2
ESO Big Diffs: 2
Table Big Diffs: 2

amirroth

Quick code walk-through.

amirroth · 2026-02-25T01:11:26Z


        auto &wm = state.dataWindowManager;
-        Array1D<Real64> sabsPhi(nume); // Glazing system absorptance for a glass layer
+        std::array<Real64, nume> sabsPhi; // Glazing system absorptance for a glass layer


Many changes like this.

amirroth · 2026-02-25T01:11:44Z

-            wm->lSimpleGlazingSystem = false;
-
+
+            bool lSimpleGlazingSystem = false;


These can be local variables.

amirroth · 2026-02-25T01:12:42Z

                // from properties at normal incidence
-                for (int IGlass = 1; IGlass <= NGlass; ++IGlass) {
-                    LayPtr = thisConstruct.LayerPoint(wm->LayerNum[IGlass - 1]);
+                for (int iGlass = 0; iGlass < NGlass; ++iGlass) {


0-based loops

amirroth · 2026-02-25T19:43:03Z

            // Loop over glass layers in the construction
-            for (int IGlass = 1; IGlass <= NGlass; ++IGlass) {
-                int LayNum = 1 + 2 * (IGlass - 1);
+            for (int iGlass = 0; iGlass < NGlass; ++iGlass) {


0-based indexing.

amirroth · 2026-02-26T14:23:21Z

-        rbt = wm->rbop[0][n - 1];
+        tt = top[n - 1][0];
+        rft = rfop[n - 1][0];
+        rbt = rbop[0][n - 1];


I found it.

amirroth · 2026-02-26T14:26:13Z

-                for (int IGlass = 1; IGlass <= NGlass; ++IGlass) {
-                    constr.AbsDiff(IGlass) = ShadeTrans * ShadeReflFac * solabsDiff(IGlass);
+                for (int iGlass = 0; iGlass < NGlass; ++iGlass) {
+                    constr.AbsDiff(iGlass+1) = ShadeTrans * ShadeReflFac * solabsDiff[iGlass];


Will transition the corresponding arrays in Construction next.

amirroth · 2026-02-26T14:32:23Z


-        RhoAir = wm->AirProps[0] + wm->AirProps[1] * (TGapOld - Constant::Kelvin);
-        ViscAir = wm->AirProps[4] + wm->AirProps[5] * (TGapOld - Constant::Kelvin);
+        RhoAir = AirDens + AirDDensDT * (TGapOld - Constant::Kelvin);


These should not be in an array, they should be discrete named constants.

amirroth · 2026-02-26T14:32:53Z


 namespace Window {

+    Real64 constexpr AirDens = 1.29;


Not sure why these were previously in an array.

amirroth · 2026-02-26T14:33:29Z

    Real64 A67 = 0.0;

    // TEMP MOVED FROM DataHeatBalance.hh -BLB
-


Made local.

amirroth · 2026-02-26T14:35:26Z

    bool HasWindows = false;
    bool HasComplexWindows = false;
    bool HasEQLWindows = false;     // equivalent layer window defined
-    Real64 SimpleGlazingSHGC = 0.0; // value of SHGC for simple glazing system block model


In general try to reduce the number of state variables unless they are actually state that persists across time steps. Don't use state to pass information from one function to another within the same timestep, that's what local variables and arguments are for.

Noted. Thanks.

mitchute

I just ran a few spot checks after merging in develop, and this is ready to go. GitHub is experiencing issues with actions currently, so we'll hold of on merging this until that is resolved.

mitchute · 2026-03-03T19:42:42Z


        auto &wm = state.dataWindowManager;
-        Array1D<Real64> sabsPhi(nume); // Glazing system absorptance for a glass layer
+        std::array<Real64, nume> sabsPhi; // Glazing system absorptance for a glass layer


mitchute · 2026-03-03T19:43:00Z

-            wm->lSimpleGlazingSystem = false;
-
+
+            bool lSimpleGlazingSystem = false;


mitchute · 2026-03-03T19:43:20Z

            // Loop over glass layers in the construction
-            for (int IGlass = 1; IGlass <= NGlass; ++IGlass) {
-                int LayNum = 1 + 2 * (IGlass - 1);
+            for (int iGlass = 0; iGlass < NGlass; ++iGlass) {


mitchute · 2026-03-03T19:43:57Z


-        RhoAir = wm->AirProps[0] + wm->AirProps[1] * (TGapOld - Constant::Kelvin);
-        ViscAir = wm->AirProps[4] + wm->AirProps[5] * (TGapOld - Constant::Kelvin);
+        RhoAir = AirDens + AirDDensDT * (TGapOld - Constant::Kelvin);


mitchute · 2026-03-03T19:46:59Z

    bool HasWindows = false;
    bool HasComplexWindows = false;
    bool HasEQLWindows = false;     // equivalent layer window defined
-    Real64 SimpleGlazingSHGC = 0.0; // value of SHGC for simple glazing system block model


Noted. Thanks.

mitchute · 2026-03-03T20:34:23Z

OK. Actions appear to be back up and running. Merging.

Amir Roth and others added 8 commits January 2, 2025 21:11

Unstate some variables

ec5b7f6

Move wavelength based calculations to std::array

296003f

Wavelength indices

211a553

Merge develop; resolve conflicts

a6ddf8c

Fix some indexing issues

c372bf6

Merge remote-tracking branch 'origin/develop' into WindowManager2

db02fb3

Fix AirDDensDT issue

5ee544b

Move maxGlassLayers arrays from Array1D to std::array

714f6d1

amirroth self-assigned this Feb 25, 2026

amirroth added Refactoring Includes code changes that don't change the functionality of the program, just perform refactoring NotIDDChange Code does not impact IDD (can be merged after IO freeze) labels Feb 25, 2026

amirroth added this to the EnergyPlus 26.1 milestone Feb 25, 2026

Amir Roth and others added 2 commits February 24, 2026 21:15

Some more transitions, trying to bisect an issue

85a2b92

More bisection

3a00ad8

Amir Roth and others added 3 commits February 25, 2026 09:22

Bisect, bisect, bisect

f462e28

Found it

6593884

Is this the cause of the small diffs?

2bf8e0e

rraustad reviewed Feb 25, 2026

View reviewed changes

Taking a stab

e515036

Amir Roth added 2 commits February 25, 2026 15:43

Undo attempted fix

56f9f74

Trying a more obvious and promising fix

bd6f673

Not sure what this is about

696ba39

amirroth commented Feb 26, 2026

View reviewed changes

Amir Roth and others added 2 commits March 1, 2026 18:00

Merge remote-tracking branch 'origin/develop' into WindowManager2

abd7f38

format

266fced

mitchute approved these changes Mar 3, 2026

View reviewed changes

mitchute merged commit 92a6e37 into develop Mar 3, 2026
11 checks passed

mitchute deleted the WindowManager2 branch March 3, 2026 20:34

mitchute mentioned this pull request Mar 13, 2026

Correct SizingMethod variable initialization #11461

Closed

25 tasks

		wm->lSimpleGlazingSystem = false;


		bool lSimpleGlazingSystem = false;

Conversation

amirroth commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Uh oh!

github-actions Bot commented Feb 25, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit c7dc965

Uh oh!

github-actions Bot commented Feb 25, 2026

⚠️ Regressions detected on macos-14 for commit c7dc965

Uh oh!

github-actions Bot commented Feb 25, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 1f95993

Uh oh!

github-actions Bot commented Feb 25, 2026

⚠️ Regressions detected on macos-14 for commit 1f95993

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 25, 2026

⚠️ Regressions detected on macos-14 for commit dc0cc45

Uh oh!

github-actions Bot commented Feb 25, 2026

⚠️ Regressions detected on macos-14 for commit 28a4e4a

Uh oh!

github-actions Bot commented Feb 25, 2026

⚠️ Regressions detected on macos-14 for commit 467bc0a

Uh oh!

amirroth left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitchute left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitchute commented Mar 3, 2026

Uh oh!

Uh oh!

Reviewers

amirroth commented Feb 25, 2026 •

edited

Loading

⚠️ Regressions detected on ubuntu-24.04 for commit `c7dc965`

⚠️ Regressions detected on macos-14 for commit `c7dc965`

⚠️ Regressions detected on ubuntu-24.04 for commit `1f95993`

⚠️ Regressions detected on macos-14 for commit `1f95993`

⚠️ Regressions detected on macos-14 for commit `dc0cc45`

⚠️ Regressions detected on macos-14 for commit `28a4e4a`

⚠️ Regressions detected on macos-14 for commit `467bc0a`