Feature/hijack blas#236
Closed
realbabilu wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Hijack BLAS
A. Layer 1 — MYSTRAN's own validation (wrapper, already proposed)
fortran! MYSTRAN_XERBLA.f90
Called explicitly from MYSTRAN source code
source with CALL MYSTRANXERBLA(...).
B. Layer 2 — Intercept OpenBLAS internal errors (weak symbol override)
Provide a separate xerbla that the static BLAS linker picks up only if the BLAS archive does not already provide one — using a Fortran or C weak symbol:
c/* xerblaoverride.c
Compiled into mystran.exe as a WEAK symbol.
If libopenblas.a provides its own xerbla (strong), that wins.
If it does not, this catches OpenBLAS internal errors.
Either way — no linker conflict because this is WEAK.
The attribute((weak)) is the key — a weak symbol loses to any strong symbol from the archive. So:
libopenblas.a has xerbla (strong) → OpenBLAS wins, no conflict
libopenblas.a has NO xerbla → weak symbol catches it