fix: clamp End alignment firstLine to 0 instead of falling back to Start#683
Merged
MohamedRejeb merged 1 commit intomainfrom Apr 24, 2026
Merged
fix: clamp End alignment firstLine to 0 instead of falling back to Start#683MohamedRejeb merged 1 commit intomainfrom
MohamedRejeb merged 1 commit intomainfrom
Conversation
Images with an intrinsic width larger than the BasicRichText container used to overflow because the inline-content Placeholder was sized upfront from the painter's intrinsic size with no awareness of the container. BasicRichText now captures its laid-out width via Modifier.onSizeChanged and publishes it through an internal LocalRichTextMaxImageWidthProvider. The Image inline content reads that value and scales width/height proportionally (aspect ratio preserved) when the intrinsic width exceeds the container. The LaunchedEffect is keyed on the container width so resizes trigger a re-clamp. No public API change — the CompositionLocal is internal. Scoped to BasicRichText only; the editor path is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Images with an intrinsic width larger than the BasicRichText container used to overflow because the inline-content Placeholder was sized upfront from the painter's intrinsic size with no awareness of the container.
BasicRichText now captures its laid-out width via Modifier.onSizeChanged and publishes it through an internal LocalRichTextMaxImageWidthProvider. The Image inline content reads that value and scales width/height proportionally (aspect ratio preserved) when the intrinsic width exceeds the container. The LaunchedEffect is keyed on the container width so resizes trigger a re-clamp.
Fixes: #423