Add progress callback support for all remeshing modules#324
Open
kmarchais wants to merge 1 commit into
Open
Conversation
bd75c98 to
282c297
Compare
282c297 to
c58ae35
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #324 +/- ##
===========================================
- Coverage 50.31% 50.24% -0.07%
===========================================
Files 177 177
Lines 47831 47913 +82
Branches 10352 10372 +20
===========================================
+ Hits 24065 24073 +8
- Misses 16037 16099 +62
- Partials 7729 7741 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional progress callback to mmg3d / mmg2d / mmgs that reports iteration progress and supports cooperative cancellation (return 0 to abort). When unset (the default), the only runtime cost is a NULL check on the existing iterative loops.
Incidental change worth flagging:
MMG5_adpdelpreviously discarded the return value ofMMG5_optbad. With this PR a cancellation can originate insideoptbad, so the return value is now checked and propagated.Happy to add a
libexamples/<module>/progress_callback/style example as a follow-up if useful.