feat(sql-agent): Added Oracle database connector with node-oracledb thin mode#5211
Open
anjumsohail wants to merge 2 commits intoMintplex-Labs:masterfrom
Open
feat(sql-agent): Added Oracle database connector with node-oracledb thin mode#5211anjumsohail wants to merge 2 commits intoMintplex-Labs:masterfrom
anjumsohail wants to merge 2 commits intoMintplex-Labs:masterfrom
Conversation
…n mode - Added OracleConnector implementation - Integrated oracledb (Thin mode) - Extended SQLEngine typedef - Updated frontend engine enum and UI selector - Registered connector in getDBClient() - Added Oracle metadata queries - Docker compatible (no Instant Client required) - Will not bloat the docker image
Author
|
Discarded Previous Branch and PR , and created a New PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
N/A
Description
This PR introduces Oracle database support for AnythingLLM by implementing an Oracle connector using the node-oracledb driver in Thin mode.
The implementation allows users to connect to Oracle databases without requiring the Oracle Instant Client, making it compatible with containerized deployments such as Docker.
Key features:
Tested against:
The implementation follows the existing database connector structure used by other supported databases to maintain consistency and backward compatibility.
Visuals (if applicable)
Additional Information
Oracle support is implemented using class-based connector OR node-oracledb Thin mode to avoid requiring Oracle Instant Client libraries, which simplifies deployment in Docker and air-gapped environments.
The implementation does not affect existing database connectors and keeps Oracle support optional.
Developer Validations
yarn lintfrom the root of the repo & committed changes