Patch 4.0.4#191
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces responder state management for popup windows and resolves a view state update issue in onAppear when using popups with SceneDelegate. The changes add callback methods to handle window responder state changes and ensure proper window key management.
Key changes:
- Added callback methods for responder state management in PopupSceneDelegate
- Enhanced Window class with scene reference and responder state handling
- Updated window initialization to include scene reference and ensure key status
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat:
Resolved problem with view state update in
onAppearin app that uses popup withSceneDelegate.Added an ability to manage the window responder state if it becomes inactive.
Fixed Issues:
189