Skip to content

Fixed the UI bug not showing already selected entries for the multi select filter#4494

Open
gabriel-bolbotina wants to merge 4 commits into
masterfrom
fix-filtering-value-relation-multiSelect
Open

Fixed the UI bug not showing already selected entries for the multi select filter#4494
gabriel-bolbotina wants to merge 4 commits into
masterfrom
fix-filtering-value-relation-multiSelect

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

@gabriel-bolbotina gabriel-bolbotina commented May 14, 2026

Solved the UI issue described in issue by converting the string values saved in currentValue to numeric ones which are used in Value Relation with AllowMulti option turned on. In this sense, the UI will show the previously selected entries from the Multi select filter.

The other bug mentioned regarding the filter itself will be solved in the QGIS plugin by modifying the template query for Value Relation with AllowMulti on to something like this:
"sql_expression": "(',' || TRIM(\"NAME_OF_FIELD\", '{}') || ',' ) LIKE '%,' || @@value@@ || ',%'" (detailed here)

Once the template query is modified, the existing business logic in the code already handles this type of filtering with "OR" option.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

Coverage Report for CI Build 26822928274

Warning

No base build found for commit 93fb13e on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 57.928%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15231
Covered Lines: 8823
Line Coverage: 57.93%
Coverage Strength: 99.36 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68411 dmg Expires: 12/08/2026 #6841
linux Build 📬 Mergin Maps 68591 x86_64 Expires: 12/08/2026 #6859
win64 Build 📬 Mergin Maps 60341 win64 Expires: 12/08/2026 #6034
Android Build 📬 Mergin Maps 815111 APK [armeabi-v7a] Expires: 12/08/2026 #8151
📬 Mergin Maps 815111 APK [armeabi-v7a] Google Play Store #8151
Android Build 📬 Mergin Maps 815151 APK [arm64-v8a] Expires: 12/08/2026 #8151
📬 Mergin Maps 815151 APK [arm64-v8a] Google Play Store #8151
iOS Build Build failed or not found. #9093

Comment thread app/qml/filters/components/MMFilterDropdownValueRelationInput.qml Outdated
Comment thread app/qml/filters/components/MMFilterDropdownValueRelationInput.qml Outdated
@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68561 dmg Expires: 17/08/2026 #6856
linux Build 📬 Mergin Maps 68741 x86_64 Expires: 17/08/2026 #6874
win64 Build 📬 Mergin Maps 60501 win64 Expires: 17/08/2026 #6050
Android Build 📬 Mergin Maps 816611 APK [armeabi-v7a] Expires: 17/08/2026 #8166
📬 Mergin Maps 816611 APK [armeabi-v7a] Google Play Store #8166
Android Build 📬 Mergin Maps 816651 APK [arm64-v8a] Expires: 17/08/2026 #8166
📬 Mergin Maps 816651 APK [arm64-v8a] Google Play Store #8166
iOS Build Build failed or not found. #9108

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68671 dmg Expires: 20/08/2026 #6867
linux Build 📬 Mergin Maps 68871 x86_64 Expires: 20/08/2026 #6887
win64 Build 📬 Mergin Maps 60611 win64 Expires: 20/08/2026 #6061
Android Build 📬 Mergin Maps 817711 APK [armeabi-v7a] Expires: 20/08/2026 #8177
📬 Mergin Maps 817711 APK [armeabi-v7a] Google Play Store #8177
Android Build 📬 Mergin Maps 817751 APK [arm64-v8a] Expires: 20/08/2026 #8177
📬 Mergin Maps 817751 APK [arm64-v8a] Google Play Store #8177
iOS Build Build failed or not found. #9119

@gabriel-bolbotina gabriel-bolbotina force-pushed the fix-filtering-value-relation-multiSelect branch from 27e598f to bbb1932 Compare June 2, 2026 13:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68801 dmg Expires: 31/08/2026 #6880
linux Build 📬 Mergin Maps 69061 x86_64 Expires: 31/08/2026 #6906
win64 Build 📬 Mergin Maps 60741 win64 Expires: 31/08/2026 #6074
Android Build 📬 Mergin Maps 819011 APK [armeabi-v7a] Expires: 31/08/2026 #8190
📬 Mergin Maps 819011 APK [armeabi-v7a] Google Play Store #8190
Android Build 📬 Mergin Maps 819051 APK [arm64-v8a] Expires: 31/08/2026 #8190
📬 Mergin Maps 819051 APK [arm64-v8a] Google Play Store #8190
iOS Build 📬 Build number: 26.06.913211 #9132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filtering does not work for fields with Value relation with Multiple selections

2 participants