Parse single-quoted GHC output more reliably#301
Closed
Conversation
9999years
force-pushed
the
wiggles/dux-2348-fix-single-quoted-ghc-output-parser
branch
from
5398873 to
c3d456c
Compare
3 tasks
GHC output contains quoted fragments:
Module graph contains a cycle:
module ‘C’ (./C.hs)
imports module ‘A’ (A.hs)
which imports module ‘B’ (./B.hs)
which imports module ‘C’ (./C.hs)
When Unicode output is not available, the Unicode quotes are substituted
for GNU-style ASCII quotes:
module `C' (./C.hs)
However, when the quoted text starts or ends with a single quote, ASCII
quotes are omitted. This leads to ambiguous output:
A → `A'
A' → A'
`A' → `A'
'A → 'A
'A' → 'A'
Correctly parsing this is challenging.
This probably increases the amount of backtracking and lookahead
required for these parsers. Not sure if that's significant or relevant.
9999years
force-pushed
the
wiggles/dux-2348-fix-single-quoted-ghc-output-parser
branch
from
c3d456c to
24fd4a1
Compare
9999years
deleted the
wiggles/dux-2348-fix-single-quoted-ghc-output-parser
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHC output contains quoted fragments:
When Unicode output is not available, the Unicode quotes are substituted for GNU-style ASCII quotes:
However, when the quoted text starts or ends with a single quote, ASCII quotes are omitted. This leads to ambiguous output:
Correctly parsing this is challenging.
This probably increases the amount of backtracking and lookahead required for these parsers. Not sure if that's significant or how concerning it is...
Split off of #297