feat(miner): add .cs to READABLE_EXTENSIONS for C# project support#1267
Open
mgattilabs wants to merge 1 commit intoMemPalace:developfrom
Open
feat(miner): add .cs to READABLE_EXTENSIONS for C# project support#1267mgattilabs wants to merge 1 commit intoMemPalace:developfrom
mgattilabs wants to merge 1 commit intoMemPalace:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(miner): add
.cstoREADABLE_EXTENSIONSfor C# project supportSummary
Adds
.cs(C#) to theREADABLE_EXTENSIONSset inminer.pyso that C# sourcefiles are picked up and indexed when mining a .NET / C# project.
Motivation
Users working on C# codebases were finding that their source files were silently
skipped during
mempalace minebecause.cswas absent from the readable-extensions allow-list. This change brings C# to parity with the other supported
languages (Python, JavaScript, TypeScript, Go, Rust, etc.).
Changes
mempalace/miner.py".cs"toREADABLE_EXTENSIONStests/test_miner.pytest_scan_project_picks_up_cs_filesto verify the extension is scannedDiff
Testing
# Run the full miner test suite (all 32 tests must pass) python -m pytest tests/test_miner.py -vAll 32 tests pass, including the new
test_scan_project_picks_up_cs_filestest.Checklist
feat/miner-add-cs-extension→ targetdeveloptest_scan_project_picks_up_cs_files)32 passed)feat(miner): add .cs to READABLE_EXTENSIONS for C# project supportPR Target
Base branch:
developHead branch:
feat/miner-add-cs-extension