fix(storage): stop ChromaDB from crashing when reopening an existing …#1262
Open
Legion345 wants to merge 1 commit intoMemPalace:developfrom
Open
fix(storage): stop ChromaDB from crashing when reopening an existing …#1262Legion345 wants to merge 1 commit intoMemPalace:developfrom
Legion345 wants to merge 1 commit intoMemPalace:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1089.
When opening an existing palace,
get_or_create_collectionwas called with hnsw metadata on every open. In ChromaDB 1.5.x, if that metadata differs from what's already stored, the Rust bindings segfault — no traceback, just a core dump. This is what causes the stop hook to crash at session end.Fix: try
get_collectionfirst, fall back tocreate_collectiononly when the collection doesn't exist yet. Existing palaces open without touching their metadata; new ones are created with the full settings as before.Credit to @jphein who described this exact approach in #1089 and has been running it on their fork since April 10 with zero crashes across 400+ starts.
How to test
Open a palace twice in the same session:
Or run the new regression tests directly:
python -m pytest tests/test_backends.py -v -k "idempotent or preserves_existing"
Checklist