Skip to content

Improve the way we update text checking features#1333

Merged
cyanzhong merged 1 commit intomainfrom
develop
Apr 6, 2026
Merged

Improve the way we update text checking features#1333
cyanzhong merged 1 commit intomainfrom
develop

Conversation

@cyanzhong
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves text checking (spellcheck/autocorrect) initialization into the CoreEditor reset path, removing the dedicated native↔web “textChecker” bridge and adding unit tests for the DOM attribute behavior.

Changes:

  • Apply text-checking attributes directly during CoreEditor.resetEditor() via a new updateTextChecker(contentDOM, options) helper.
  • Remove the textChecker web module/Swift bridge plumbing (WebModuleBridge.textChecker, generated WebBridgeTextChecker, and the CoreEditor web bridge module).
  • Add Jest coverage validating spellcheck/autocorrect attributes and removal of autocomplete/autocapitalize.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
MarkEditMac/Sources/Editor/Controllers/EditorViewController.swift Stops invoking text-checker updates from native during editor reset; uses weak capture in reset completion.
MarkEditKit/Sources/Bridge/Web/WebModuleBridge.swift Removes the public textChecker bridge property/initializer wiring.
MarkEditKit/Sources/Bridge/Web/Generated/WebBridgeTextChecker.swift Deletes the generated Swift web bridge for text-checker updates/options.
CoreEditor/src/modules/textChecker/index.ts Refactors to updateTextChecker(contentDOM, options) to avoid relying on window.editor.
CoreEditor/src/core.ts Initializes text checking during editor reset by calling updateTextChecker.
CoreEditor/src/bridge/web/textChecker.ts Removes the web-module bridge interface/implementation for text checker.
CoreEditor/index.ts Removes registration of the textChecker web module.
CoreEditor/test/textChecker.test.ts Adds Jest tests validating text-checker DOM attribute behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cyanzhong cyanzhong merged commit 01db168 into main Apr 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants