Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves text checking (spellcheck/autocorrect) initialization into the CoreEditor reset path, removing the dedicated native↔web “textChecker” bridge and adding unit tests for the DOM attribute behavior.
Changes:
- Apply text-checking attributes directly during
CoreEditor.resetEditor()via a newupdateTextChecker(contentDOM, options)helper. - Remove the
textCheckerweb module/Swift bridge plumbing (WebModuleBridge.textChecker, generatedWebBridgeTextChecker, and the CoreEditor web bridge module). - Add Jest coverage validating spellcheck/autocorrect attributes and removal of autocomplete/autocapitalize.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| MarkEditMac/Sources/Editor/Controllers/EditorViewController.swift | Stops invoking text-checker updates from native during editor reset; uses weak capture in reset completion. |
| MarkEditKit/Sources/Bridge/Web/WebModuleBridge.swift | Removes the public textChecker bridge property/initializer wiring. |
| MarkEditKit/Sources/Bridge/Web/Generated/WebBridgeTextChecker.swift | Deletes the generated Swift web bridge for text-checker updates/options. |
| CoreEditor/src/modules/textChecker/index.ts | Refactors to updateTextChecker(contentDOM, options) to avoid relying on window.editor. |
| CoreEditor/src/core.ts | Initializes text checking during editor reset by calling updateTextChecker. |
| CoreEditor/src/bridge/web/textChecker.ts | Removes the web-module bridge interface/implementation for text checker. |
| CoreEditor/index.ts | Removes registration of the textChecker web module. |
| CoreEditor/test/textChecker.test.ts | Adds Jest tests validating text-checker DOM attribute behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.