workspaces: make button width scale to fit names#740
Open
LukeCarrier wants to merge 2 commits into
Open
Conversation
Now that workspaces' buttons are of variable width due to scaling to the fit the workspace name, we need to visually distinguish between active and inactive workspaces through some other means. Inverting colors should let us preserve the existing workspace color options.
MalpenZibo
reviewed
May 11, 2026
Owner
MalpenZibo
left a comment
MalpenZibo
left a comment
There was a problem hiding this comment.
I recently added the workspace animation that works with the fixed width of the button so I need to rethink the solution to address this bug
Author
|
Would it make sense to use colour in place of item width to differentiate between active and inactive workspaces, and those which have contents and those which don't? That's what my second commit was doing here, but I wasn't really sure if you'd want changes to the theme. No rush, I am happy to run this patch in the meantime. ashell is an awesome piece of software and is a major upgrade over my janky Waybar configuration -- thank you for maintaining it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bind a keyboard shortcut Super + R to set the name of each space, and I generally set the names to those of the projects I'm working on. In current ashell releases this results in overlapping text as soon as names are over 1-2 characters in length.
Make the workspace buttons width shrink to fit the workspace names, and differentiate between them with colours rather than borders.