feat: lazy TF session init - defer GPU probe until model load#1501
Open
xiaden wants to merge 1 commit intoMTG:masterfrom
Open
feat: lazy TF session init - defer GPU probe until model load#1501xiaden wants to merge 1 commit intoMTG:masterfrom
xiaden wants to merge 1 commit intoMTG:masterfrom
Conversation
Contributor
|
Hi @xiaden, @dbogdanov, we can merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer TensorFlow graph/session creation from the constructor to configure().
Description
Previously, TensorFlow session creation occurred in the constructor, causing GPU device probing (and associated log output) when essentia.standard was imported — even if no TensorFlow-based algorithms were used.
This change defers TF object creation until TensorflowPredict::configure() is called with a valid model path.
Behavior Change
The session is still created before compute() runs, so runtime behavior for valid usage remains unchanged.
The only observable difference is that GPU probing logs now appear at model load time instead of import time.
Notes
Adds guards in destructor and reset() to handle uninitialized TF objects safely.
Prevents unnecessary GPU probing when TensorFlow algorithms are registered but never used.
The changes were implemented with AI assistance, and I’m not deeply familiar with all invariants in this codebase, so I’d appreciate careful review.