Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
apt 28vsapt 29), which creates noisy high-similarity matches; the change aims to reduce these false positives while keeping comparisons focused on non-numeric content.Description
strip_numeric_tokens()to remove digit sequences from normalized names andnumeric_tokens()to extract numeric token sequences.find_similar_name_pairs()to skip candidate pairs when both names contain numeric tokens, share the same non-numeric stem, but have different numeric sequences.SequenceMatcher) unchanged.Testing
python3 -m py_compile tools/threat_actor_similarity_report.pywhich succeeded.python3 tools/threat_actor_similarity_report.py --help | head -n 20to validate CLI help which printed successfully.python3 tools/threat_actor_similarity_report.py --max-results 5 --markdown-output /tmp/threat_report.md --json-output /tmp/threat_report.jsonwhich produced a report and JSON file, printing analysis summary (reports written) with no errors.Codex Task