Solve underlying problem#362
Open
Axxxeel89 wants to merge 15 commits intoLu-Yi-Hsun:masterfrom
Open
Conversation
|
Hello. Your PR solve this (Issue message). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improves the get_all_open_time method by:
Ignoring the stray “underlying” key in the v2 init payload to prevent KeyError.
Respecting each asset’s is_suspended flag, so OTC/Turbo instruments are only marked open when truly available.
Adding robust error handling around digital, forex, crypto, and CFD schedules—any API failure in one section no longer breaks the entire loop.
Together, these changes prevent silent crashes when the platform payload changes, avoid phantom “open” assets that are actually suspended, and make the open-time lookup far more resilient.