Refactor index.js & add more tests#223
Open
mfeniseycopes wants to merge 5 commits intoLogRocket:masterfrom
Open
Refactor index.js & add more tests#223mfeniseycopes wants to merge 5 commits intoLogRocket:masterfrom
mfeniseycopes wants to merge 5 commits intoLogRocket:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
===========================================
- Coverage 83.56% 69.34% -14.22%
===========================================
Files 5 5
Lines 146 137 -9
===========================================
- Hits 122 95 -27
- Misses 24 42 +18
Continue to review full report at Codecov.
|
Collaborator
|
Sorry for delay, will review on this week. |
Collaborator
|
But it looks pretty good! |
imevro
reviewed
May 17, 2017
src/index.js
Outdated
| logErrors, | ||
| diffPredicate, | ||
| } = loggerOptions; | ||
| function noLogger(options) { |
Collaborator
|
Can you please fix merge conflicts? |
Author
|
Renamed |
Author
|
@evgenyrodionov Have you had a chance to look this over? |
Collaborator
|
@mfeniseycopes yes, after #234. Sorry for a delay, too busy now. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
index.jsto utilize more helper methods and make code more semantic. No changes in logic or naming conventions, just shifting things around. Also, moves early returns to the top of createLogger to prevent unnecessary assignments and variable creation.Also, adds more specs to
index.spec.js(still needs more though) and moves helper tests tohelpers.spec.js.Let me know what you think!