Enhance expression evaluation and update event sheet resources#85
Open
Lexian-droid wants to merge 3 commits intomasterfrom
Open
Enhance expression evaluation and update event sheet resources#85Lexian-droid wants to merge 3 commits intomasterfrom
Lexian-droid wants to merge 3 commits intomasterfrom
Conversation
…idation; update event sheet resources to escape string values.
…ng; update scene paths for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the
FKExpressionEvaluatorin FlowKit, primarily adding type validation to expression evaluation and updating event sheet resources to use explicit string quoting for literal values. The evaluator now validates result types against expected types, and event sheet.tresfiles have been updated for consistency with the new evaluation logic.Core Expression Evaluation Improvements
evaluatefunction inexpression_evaluator.gdnow takes an optionalexpected_typeparameter, validating the result type after evaluation. If the type does not match, an error is pushed. The evaluation no longer falls back to returning the raw string if evaluation fails, but instead returnsnulland logs an error. [1] [2]_try_parse_literal,_evaluate_expression) now return[found: bool, value: Variant]arrays to distinguish between "not found" and "found with null value" cases, improving reliability and error handling. [1] [2] [3]_check_typefor validating result types, andtype_name_to_variant_typefor mapping string type names to Godot Variant types.Bulk Event Sheet Updates for Literal Quoting
.tresevent sheet files to wrap string literal values in quotes (e.g.,"windowed"instead ofwindowed) for keys such as"Mode","Name","color","message","Key", etc., ensuring they are parsed as string literals under the new evaluation logic. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25]API Enhancements
evaluate_inputsfunction now accepts an optionaltype_hintsdictionary, allowing per-input type validation during batch evaluation.These changes improve the safety, predictability, and clarity of expression evaluation in FlowKit, and ensure event sheet resources are compatible with stricter type handling.