Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
At first, filters would simply exist as a single instance, so they update the url on filter change etc. We then separated them into a "separate" entity that could be re-used for multiple purposes, and for those cases, if multiple filter nav-bars were to be setup on the same page, they can no longer update the url, but they required for that state to be "stored" somewhere, so that it can be restored/cleaned properly.
AFTER - What is happening after this PR?
This PR introduces
data-filter-paramsin the filters navbar, ensuring that the filter state always has a place to be stored, even when using multiple filter navbars on the same page.