Added Json instance overload to readJson(inputStream, ...)#1869
Open
Jolanrensen wants to merge 4 commits into
Open
Added Json instance overload to readJson(inputStream, ...)#1869Jolanrensen wants to merge 4 commits into
readJson(inputStream, ...)#1869Jolanrensen wants to merge 4 commits into
Conversation
…n, so users have the ability to override it #459
…en reading difficult json in the documentation
…json to be read as string
38224db to
659b2c0
Compare
koperagen
reviewed
May 21, 2026
| keyValuePaths: List<JsonPath> = emptyList(), | ||
| typeClashTactic: TypeClashTactic = ARRAY_AND_VALUE_COLUMNS, | ||
| unifyNumbers: Boolean = true, | ||
| jsonInstance: Json = Json.Default, |
Collaborator
There was a problem hiding this comment.
Hmm, not sure i really like this name. configuration maybe? Maybe reference from other libraries (kotlinx.serialization probably only ever uses it as receiver?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #459
In the same vein as
readCsv/readTsv/readDelim, the overload that takes anInputStreamnow gains an underlying-library-specific parameter to customize how it parses from the stream. This is an advanced use-case, but it can prevent users having to first manually parse their JSON manually before passing it onto DataFrame.Since it's an advanced feature, only adding it to the
InputStreamoverload makes sense. If we ever swap out the underlying library, only this function would break.New example: