Sync login status between different windows. [INS-2537]#9908
Open
yaoweiprc wants to merge 2 commits into
Open
Conversation
✅ Circular References ReportGenerated at: 2026-05-08T08:57:33.988Z Summary
Click to view all circular references in PR (19)Click to view all circular references in base branch (19)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs authentication state across multiple application windows by broadcasting login/logout changes from the main process to all renderer windows and reacting in the root router to redirect accordingly.
Changes:
- Added a renderer listener for a new
loggedInIPC broadcast to navigate to/organization(login) or/auth/login(logout). - Updated the
loginStateChangebridge API and IPC handler to carry anisLoggedIn: booleanpayload and broadcast it to windows. - Updated session login/logout code to emit explicit
true/falselogin state.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/insomnia/src/root.tsx | Subscribes to loggedIn IPC event and navigates based on login state. |
| packages/insomnia/src/main/ipc/main.ts | Extends bridge API and broadcasts loggedIn with a boolean payload on loginStateChange. |
| packages/insomnia/src/entry.preload.ts | Sends the boolean payload from renderer to main for loginStateChange. |
| packages/insomnia/src/account/session.ts | Emits loginStateChange(true/false) after session creation and during logout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+281
to
284
| ipcMainOn('loginStateChange', async (_, isLoggedIn: boolean) => { | ||
| BrowserWindow.getAllWindows().forEach(w => { | ||
| w.webContents.send('loggedIn'); | ||
| w.webContents.send('loggedIn', isLoggedIn); | ||
| }); |
Comment on lines
43
to
46
| ); | ||
|
|
||
| window.main.loginStateChange(); | ||
| window.main.loginStateChange(true); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video.Project.2.mp4