Add --profiles-dir argument to cargo pgo bolt {build,optimize}#84
Merged
Kobzol merged 1 commit intoKobzol:mainfrom Apr 25, 2026
Merged
Conversation
Kobzol
approved these changes
Apr 25, 2026
Owner
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Hi, sorry for the delay, super busy at the moment.
Yeah, this shows that my design for bolt was a bit bolted on :) the pgo commands, it should have been done a bit differently perhaps. In any case, although this maybe deserves some refactoring overall, I'm fine with the change.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR basically implements
get_bolt_directoryin such a way that the user can supply their own profiles directory.To remain backwards compatible I did not rename
cargo pgo clean --profiles-dirtocargo pgo clean --pgo-profiles-dir, but it adds a bit of an assymetry with the newly addedcargo pgo clean --bolt-profiles-dirsubcommand.