Expose url_path_for on HTTPConnection#2872
Closed
judahrand wants to merge 6 commits intoKludex:masterfrom
Closed
Conversation
68796fd to
6042901
Compare
6042901 to
f56b91f
Compare
Contributor
|
The difference between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on the conclusion of #604 which can be found here the consensus seems to be that trying to munge host headers when located behind a reverse proxy isn't the best approach and that instead absolute paths should be used in redirects. The same, I imagine, should apply in tempates.
This is currently possible but would be made easier/neater if the
url_path_formethod which exists onStarlettewas exposed on theHTTPConnectionand therefore theRequest. Additionally, adding aurl_path_forjinjafunction would allow for this to be achieved in templates much easier.I leave this PR here for review with the knowledge that if this approach is approved of docs will also need to be added.
Checklist