Skip to content

feat(segmentation): Add draw segmentation effect#58

Merged
Thibault-Pelletier merged 1 commit intomainfrom
draw-segmentation-effect
Apr 1, 2026
Merged

feat(segmentation): Add draw segmentation effect#58
Thibault-Pelletier merged 1 commit intomainfrom
draw-segmentation-effect

Conversation

@Jo-Byr
Copy link
Copy Markdown
Collaborator

@Jo-Byr Jo-Byr commented Dec 22, 2025

No description provided.

@Jo-Byr Jo-Byr marked this pull request as draft December 22, 2025 10:13
@Jo-Byr
Copy link
Copy Markdown
Collaborator Author

Jo-Byr commented Dec 22, 2025

@Thibault-Pelletier I duplicated an important part of the scissors effect, we probably want to factorize some of it.

@Thibault-Pelletier
Copy link
Copy Markdown
Collaborator

Thx for the PR!
If you have duplicated logic from the scissors effect, could you factorize both so that we can have reusable components?

It would also be nice to add a unit test for the new draw effect.

@Jo-Byr Jo-Byr force-pushed the draw-segmentation-effect branch from 76789fc to f2c457c Compare March 17, 2026 12:24
@Jo-Byr Jo-Byr marked this pull request as ready for review March 17, 2026 12:25
@Jo-Byr Jo-Byr force-pushed the draw-segmentation-effect branch from f2c457c to 0c12642 Compare March 30, 2026 14:19
@Jo-Byr
Copy link
Copy Markdown
Collaborator Author

Jo-Byr commented Mar 30, 2026

@Thibault-Pelletier I restarted this branch from scratch based on the new scissors effect

@Thibault-Pelletier Thibault-Pelletier force-pushed the draw-segmentation-effect branch from 0c12642 to 4ee47f0 Compare April 1, 2026 06:57
@Thibault-Pelletier Thibault-Pelletier merged commit 4839a03 into main Apr 1, 2026
3 checks passed
@Thibault-Pelletier Thibault-Pelletier deleted the draw-segmentation-effect branch April 1, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants