Skip to content

Segmentation UI#54

Merged
Thibault-Pelletier merged 1 commit intomainfrom
segmentation-ui
Dec 8, 2025
Merged

Segmentation UI#54
Thibault-Pelletier merged 1 commit intomainfrom
segmentation-ui

Conversation

@Justineantoine
Copy link
Copy Markdown
Collaborator

No description provided.

@Justineantoine Justineantoine marked this pull request as draft December 3, 2025 11:18
Comment thread examples/segmentation_viewer_app.py Outdated
Comment thread examples/segmentation_viewer_app.py Outdated
Comment thread examples/segmentation_viewer_app.py Outdated
Comment thread examples/viewer_lib/logic/segmentation/segment_edit_logic.py Outdated
Comment thread examples/viewer_lib/ui/segmentation/segment_rendering_ui.py Outdated
Comment thread examples/viewer_lib/ui/utils/__init__.py Outdated
Comment thread examples/viewer_lib/ui/utils/abstract_tool.py Outdated
Comment thread examples/viewer_lib/ui/utils/components.py Outdated
Comment thread examples/viewer_lib/ui/utils/components.py Outdated
Comment thread tests/test_medical_view_example.py Outdated
@Justineantoine Justineantoine force-pushed the segmentation-ui branch 5 times, most recently from 04cdca0 to 0a3a618 Compare December 4, 2025 15:09
@Justineantoine Justineantoine marked this pull request as ready for review December 4, 2025 15:10
@Justineantoine Justineantoine force-pushed the segmentation-ui branch 2 times, most recently from de2b276 to 26a4d96 Compare December 8, 2025 15:05
elif self._typed_state.data.mode == IslandsSegmentationMode.REMOVE_SMALL_ISLANDS:
self.effect.remove_small_islands(self._typed_state.data.minimum_size)
elif self._typed_state.data.mode == IslandsSegmentationMode.SPLIT_TO_SEGMENTS:
elif self._typed_state.data.mode == IslandsSegmentationMode.SPLIT_TO_SEGMENT:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IslandsSegmentationMode.SPLIT_TO_SEGMENT > IslandsSegmentationMode.SPLIT_TO_SEGMENTS

@Thibault-Pelletier
Copy link
Copy Markdown
Collaborator

LGTM! Thx for the PR!

@Thibault-Pelletier Thibault-Pelletier merged commit 56d9cce into main Dec 8, 2025
3 checks passed
@Thibault-Pelletier Thibault-Pelletier deleted the segmentation-ui branch December 8, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants