feat(segmentation): add island segmentation effect#51
Merged
Thibault-Pelletier merged 2 commits intomainfrom Dec 1, 2025
Merged
feat(segmentation): add island segmentation effect#51Thibault-Pelletier merged 2 commits intomainfrom
Thibault-Pelletier merged 2 commits intomainfrom
Conversation
Thibault-Pelletier
changed the title
Thibault-Pelletier
changed the title
| assert effect.is_active | ||
|
|
||
| # Should do nothing | ||
| effect.apply(segment_id, None, minimum_size=0, split=False) |
Collaborator
There was a problem hiding this comment.
Please break the unit test in multiple unit tests instead of undo / redo.
As for other parts of the code, unit tests should follow the single responsibility principle and test only one feature at a time.
Collaborator
There was a problem hiding this comment.
Thanks for the split.
To make the test better, it's better to make the test name explicit (given / when / then structure).
A better name would be : test_with_0_min_voxel_size_remove_small_islands_does_nothing (please update the different test names)
Please also update the tests to use the specialized API and not a generic apply.
Collaborator
Author
There was a problem hiding this comment.
Can you review the test again ?
Jo-Byr
force-pushed
the
island-segmentation
branch
from
702c5ba to
0095647
Compare
| max_number_of_segments=1, | ||
| split=False, | ||
| ) | ||
| elif self._typed_state.data.mode == IslandsSegmentationMode.REMOVE_SMALL_ISLANDS.value: |
Collaborator
There was a problem hiding this comment.
Linked comment with the IslandState dataclass, the typed state mode should be a IslandsSegmentationMode instance directly and not a raw int.
Collaborator
Author
There was a problem hiding this comment.
I ended up needing to use encode rather than checking direct equality
Jo-Byr
force-pushed
the
island-segmentation
branch
from
de44948 to
6c7f175
Compare
Jo-Byr
force-pushed
the
island-segmentation
branch
2 times, most recently
from
af13c49 to
5ac8142
Compare
Jo-Byr
force-pushed
the
island-segmentation
branch
from
5ac8142 to
a66d642
Compare
Thibault-Pelletier
force-pushed
the
island-segmentation
branch
from
a66d642 to
75f176a
Compare
Add logic and unit test for island segmentation Add button for island segmentation in medical example Bump test data submodule version
Thibault-Pelletier
force-pushed
the
island-segmentation
branch
from
75f176a to
e60a649
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logic and unit test for island segmentation
Add button for island segmentation in medical example