Do not allow users to enter sketches if there are parser errors#10849
Merged
franknoirot merged 7 commits intomainfrom Apr 7, 2026
Merged
Do not allow users to enter sketches if there are parser errors#10849franknoirot merged 7 commits intomainfrom
franknoirot merged 7 commits intomainfrom
Conversation
It's possible to unrecoverably overwrite your file's contents by entering sketch mode when you have parser errors. This Codex-written PR prevents that, and adds a unit test for it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jacebrowning
reviewed
Apr 6, 2026
jacebrowning
reviewed
Apr 6, 2026
jacebrowning
approved these changes
Apr 6, 2026
Co-authored-by: Jace Browning <[email protected]>
Co-authored-by: Jace Browning <[email protected]>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible to unrecoverably overwrite your file's contents by entering sketch mode when you have parser errors. This Codex-written PR prevents that, and adds an integration test for it.
Demo
Screenshare.-.2026-04-06.2_59_17.PM-compressed.mp4