KCL: Enable sweeping regions, and sweeping along sketch lines#10832
KCL: Enable sweeping regions, and sweeping along sketch lines#10832adamchalmers merged 15 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merging this PR will not alter performance
Comparing Footnotes
|
26e7bfb to
83bab7a
Compare
7afff7a to
5d63f3d
Compare
| } | ||
| SegmentTraversal::Reverse => { | ||
| if end_radians >= start_radians { | ||
| end_radians -= std::f64::consts::TAU; |
There was a problem hiding this comment.
We should have an actual sim test or other automated test for this case. Not sure if one was made already.
There was a problem hiding this comment.
Yeah, here's an example of a successful sweep:
The path is a straight line and a tangential arc. The path is joined via coincident([line1.end, arc1.end]).
// Sketch a path
sketch002 = sketch(on = offsetPlane(YZ, offset = -2)) {
line1 = line(start = [..], end = [..])
arc1 = arc(start = [..], end = [..], center = [..])
coincident([line1.end, arc1.end])
tangent([line1, arc1])
}
// Sweep the square along the path.
path = [sketch002.line1, sketch002.arc1]
sweep(mySquare, path)In a multi-segment path like [A, B, C], check that B.start matches A.end and if not, flip B.
I expect several removed MovePathPenTo, because coincident line chains no longer need to move the path pen.
402f68f to
f550e3f
Compare
Part of #10728
Adds support for: