fix: Fix the result disorder caused by multiprocessing queue.#12
Open
tripletpoi wants to merge 2 commits intomainfrom
Open
fix: Fix the result disorder caused by multiprocessing queue.#12tripletpoi wants to merge 2 commits intomainfrom
tripletpoi wants to merge 2 commits intomainfrom
Conversation
|
In superAnalyzer.py, the current multiprocessing result collection looks incorrect and can still cause replica mix-ups when n_parallel > 1.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix misordered results caused by multiprocessing queue
Background
When running analyzers in parallel, results were collected from a
multiprocessing.Queue.However,
Queue.get()retrieves items in the order they arrive, not in the order tasks were submitted.This caused inconsistent or misordered results when multiple worker processes finished at different speeds.
What was happening
This led to incorrect or unstable output in several analyzer modules.
What this PR does
(task_id, result)a_d.pyassociation.pydissociation.pyee.pyrmsd.pysuperAnalyzer.pytarget.pyTesting
time.sleep()calls insidecalculate_cv()to simulate unpredictable worker timing