Skip to content

Proposal: Truncate to shortest track (if video)#30

Open
stewieoO wants to merge 5 commits into
KirovAir:masterfrom
stewieoO:handle-different-stream-lengths
Open

Proposal: Truncate to shortest track (if video)#30
stewieoO wants to merge 5 commits into
KirovAir:masterfrom
stewieoO:handle-different-stream-lengths

Conversation

@stewieoO
Copy link
Copy Markdown
Contributor

@stewieoO stewieoO commented Apr 10, 2026

This is just a rough implementation (without the actual truncating atm) as a proposal

  • How should the change be shown in the preview/conversion table? (Obviously need to properly format a display value 😆
  • Probably also want to show a warning kinda tag somewhere on the detail page indicating that the different lengths will be an issue
  • Could also check if the difference is relevant for the threshold
  • Write tests (how do you create those dummy mkv files for testing?)

Setting in profiles
image

Library view
image

image

@stewieoO
Copy link
Copy Markdown
Contributor Author

@KirovAir forgot to mention you, so idk if you saw it.
Could you give your thoughts on this?

@KirovAir
Copy link
Copy Markdown
Owner

Hi! Sorry for the late response I was extremely busy at work and just working on a big refactor in how the remuxing works for future expansions. This is nearly finished and will most likely break the PR. For length detection I'll add that but I am still doubting about the -shortest flag since it will possibly open up a can of worms to fix all sorts of "possible" broken files which need to be fixed in different sort of ways.
I'll most likely expand the pre/post processing to be more advanced so you can modify the actual command that will be used or that can be used afterwards to fix the tracks. :)

@stewieoO
Copy link
Copy Markdown
Contributor Author

Hi! Sorry for the late response I was extremely busy at work and just working on a big refactor in how the remuxing works for future expansions. This is nearly finished and will most likely break the PR. For length detection I'll add that but I am still doubting about the -shortest flag since it will possibly open up a can of worms to fix all sorts of "possible" broken files which need to be fixed in different sort of ways. I'll most likely expand the pre/post processing to be more advanced so you can modify the actual command that will be used or that can be used afterwards to fix the tracks. :)

No worries (for the late response).
I only made the pr as a UI suggestion anyways.

Not sure what other possible ways of "broken" but not actually broken there are tbh 😆 These files play totally fine in any video player i tried. It's just the mismatch between different tracks.
I would def argue that it should be a core functionality (although optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants