Merged
Conversation
This allows us to mount as a local path (the current default) or purely inside the container. This will make it possible to have a container only mount, for the purpose of writing config to a secure location for dns-cloudflare.
As we're no longer using route53, certbot was unable to perform the dns challenge to renew the certificate. This switches to using dns-cloudflare to perform a similar function. The main challenge was that the official container only supports a file or cli switch for the token. Which is suboptimnal. The awscli container was added as a dependency to pull the token into a ephemeral container volume shared with certbot so it can authenticate. A couple of small work arounds have been added to keep the change set tightly scoped. But this is prod as it is deployed right now.
HebaruSan
reviewed
Nov 28, 2025
Member
HebaruSan
left a comment
HebaruSan
left a comment
There was a problem hiding this comment.
I don't understand this and can't test it, so I can't help decide whether to merge.
Member
Author
|
All good, there are no triggers, but this is as deployed, so is more of a reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we're no longer using route53, certbot was unable to perform the dns challenge to renew the certificate. This switches to using dns-cloudflare to perform a similar function.
The main challenge was that the official container only supports a file or cli switch for the token. Which is suboptimnal. The awscli container was added as a dependency to pull the token into a ephemeral container volume shared with certbot so it can authenticate.
A couple of small work arounds have been added to keep the change set tightly scoped. But this is prod as it is deployed right now.