Skip to content

Uppercase ¿#54

Open
longemen3000 wants to merge 2 commits into
JuliaIntro:masterfrom
longemen3000:master
Open

Uppercase ¿#54
longemen3000 wants to merge 2 commits into
JuliaIntro:masterfrom
longemen3000:master

Conversation

@longemen3000
Copy link
Copy Markdown
Collaborator

I checked every chapter for the presence of lowercase letters after ¿

@longemen3000 longemen3000 requested a review from chrisvwx October 30, 2020 23:25
@chrisvwx chrisvwx requested review from lventosa and removed request for chrisvwx October 31, 2020 18:01
@chrisvwx
Copy link
Copy Markdown
Member

Thanks for the PR!

Because I barely can read or speak Spanish I don't think I am the right person to review this PR. I believe @lventosa had something to say about capitalization after ¿ in another issue

@lventosa
Copy link
Copy Markdown
Contributor

lventosa commented Nov 2, 2020

Yeah, I don't think all changes introduced are correct. After ¿ there's only an uppercase letter if that word starts a sentence. Example:
Blah blah (unrelated sentence). ¿Cómo te llamas? vs. Hola, ¿cómo te llamas?

@miguelraz
Copy link
Copy Markdown

From a quick revision, all the highlighted cases are spurious following what @lventosa said.
I would recommend salvaging the correct ones or closing.

@chrisvwx
Copy link
Copy Markdown
Member

@longemen3000 are you interested in updating your PR? If not, please close it.

@longemen3000
Copy link
Copy Markdown
Collaborator Author

Let me check, if there are only wrong changes, feel free to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants