Skip to content

CompatHelper: bump compat for Makie in [weakdeps] to 0.24, (keep existing compat)#34

Merged
peremato merged 1 commit intomasterfrom
compathelper/new_version/2025-07-08-00-21-41-003-02779657399
Sep 2, 2025
Merged

CompatHelper: bump compat for Makie in [weakdeps] to 0.24, (keep existing compat)#34
peremato merged 1 commit intomasterfrom
compathelper/new_version/2025-07-08-00-21-41-003-02779657399

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jul 8, 2025

This pull request changes the compat entry for the Makie package from 0.22, 0.23 to 0.22, 0.23, 0.24.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@peremato peremato force-pushed the compathelper/new_version/2025-07-08-00-21-41-003-02779657399 branch from 9a15cdc to 5313b62 Compare July 8, 2025 00:21
@fhagemann
Copy link
Copy Markdown
Contributor

I do not 100% understand the workflow, but it looks like for this to work from a package compatibility point of view, one would need a new version of Geant4_julia_jll which allows for [email protected] (and maybe more stuff, but it's not too obvious now).
What would be the steps to initiate this?

@Moelf
Copy link
Copy Markdown
Member

Moelf commented Aug 9, 2025

https://github.com/JuliaPackaging/Yggdrasil/blob/bb30e55275c0c05913bd76fa277da1986e173748/G/Geant4_julia/build_tarballs.jl#L65

basically we need to try to build a new one by bumping compatibility of this line.

@fhagemann
Copy link
Copy Markdown
Contributor

Who could take care of this? 😇

@Moelf
Copy link
Copy Markdown
Member

Moelf commented Aug 10, 2025

historically @peremato but any of us can take a try at it

edit: I tried, and saw:

/workspace/srcdir/src/cpp/jlGeant4.cxx:505:3: error: static assertion failed: The code was generated with WrapIt! for a different CxxWrap version (controlled with the cxxwrap_version parameter).

this makes sense, https://github.com/peremato/Geant4_cxxwrap is generated by WrapIt, and I guess I don't know how to do that yet.

@fhagemann
Copy link
Copy Markdown
Contributor

@Yuan-Ru-Lin Did you do something similar for #18 ?

@Yuan-Ru-Lin
Copy link
Copy Markdown
Member

To be honest, I don't know whether what I did is related to the problem right now, but I basically just

  1. Pkg.developed Geant4.jl
    using Pkg
    pkg"activate --temp"
    pkg"dev Geant4"
  2. Then installed wrapit and include("build.jl"), which depends on wrapit, in gen/, one of the sub-directory under the developed package
    cd $JULIA_DEPOT_PATH/dev/Geant4/gen
    PATH="$PWD:$PATH" julia --project=.
    using Pkg; pkg"instantiate"
    using WrapIt
    WrapIt.install() # install the binary in the PWD.
    include("build.jl")

CMake doesn't like some cxx flags when I did it ten minutes ago but it shouldn't take too long to fix, if this is what we want to do.

@fhagemann
Copy link
Copy Markdown
Contributor

@peremato Is this something that could also become part of the new release 0.2.3?

@peremato
Copy link
Copy Markdown
Member

@fhagemann I am a bit confused. What is "this" for you? The changes in compat?

@fhagemann
Copy link
Copy Markdown
Contributor

fhagemann commented Aug 29, 2025

Yes, adding [email protected] to the compat (and maybe checking that it works well).
If we rebase this onto the current master, we can check if the tests pass.

@peremato peremato merged commit d727468 into master Sep 2, 2025
2 of 5 checks passed
@Moelf Moelf deleted the compathelper/new_version/2025-07-08-00-21-41-003-02779657399 branch September 2, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants