build(agents): properly ignore all wasm publsihing tasks for otel module#1975
Open
EugeneTheDev wants to merge 1 commit intodevelopfrom
Open
build(agents): properly ignore all wasm publsihing tasks for otel module#1975EugeneTheDev wants to merge 1 commit intodevelopfrom
EugeneTheDev wants to merge 1 commit intodevelopfrom
Conversation
Collaborator
Author
|
I don't know why |
sdubov
approved these changes
May 11, 2026
| tasks.matching { it.name.startsWith("wasmJs") || it.name == "compileKotlinWasmJs" || it.name == "compileTestKotlinWasmJs" }.configureEach { | ||
| // Match both camelCase prefixed tasks (wasmJsJar, wasmJsSourcesJar, ...) and PascalCase | ||
| // suffixed ones (compileKotlinWasmJs, generateMetadataFileForWasmJsPublication, ...). | ||
| tasks.matching { it.name.startsWith("wasmJs") || it.name.contains("WasmJs") }.configureEach { |
Collaborator
There was a problem hiding this comment.
This can be re-written to:
tasks.matching { it.name.contains("wasmjs", ignoreCase = true) }.configureEach { ... }
However, let me check if we can disable wasm target in more solid way. I'm not sure that this check for task name is the best we can do here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing task filter only matched names starting with wasmJs, so publication tasks like generateMetadataFileForWasmJsPublication (where WasmJs appears mid-name) slipped through and failed reading the klib that the disabled compileKotlinWasmJs never produced. Broadened the filter to also match contains("WasmJs")