fix(agents): KG-808. SpanAdapter hooks run on fully prepared spans in OpenTelemetry feature#1969
Merged
fix(agents): KG-808. SpanAdapter hooks run on fully prepared spans in OpenTelemetry feature#1969
Conversation
serge-p7v
approved these changes
May 8, 2026
qflen
reviewed
May 8, 2026
Comment on lines
+170
to
+171
| * @param serverAddress The server address for a client spans (recommended). | ||
| * @param serverPort The server port for a client spans (recommended). |
There was a problem hiding this comment.
Suggested change
| * @param serverAddress The server address for a client spans (recommended). | |
| * @param serverPort The server port for a client spans (recommended). | |
| * @param serverAddress The server address for client spans (recommended). | |
| * @param serverPort The server port for client spans (recommended). |
… OpenTelemetry feature - `OpenTelemetry.kt` previously invoked `SpanAdapter.onBeforeSpanFinished` before `end<span_name>Span` had populated final attributes, so adapters such as Langfuse and Weave never observed them. - Each start and end span helpers now take a `SpanAdapter` and invokes the corresponding hook internally, after all attributes are set and right before the span is started or ended. - MCP enrichment for tool-call spans moved inside `startExecuteToolSpan` via a new optional `mcpToolMetadata` parameter; `mcpClientSpan.kt` is gone, its helper is now private inside `executeToolSpan.kt`. closes: [KG-808](https://youtrack.jetbrains.com/issue/KG-808)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTelemetry.ktpreviously invokedSpanAdapter.onBeforeSpanFinishedbeforeend<span_name>Spanhad populated final attributes, so adapters such as Langfuse and Weave never observed them.SpanAdapterand invokes the corresponding hook internally, after all attributes are set and right before the span is started or ended.startExecuteToolSpanvia a new optionalmcpToolMetadataparameter;mcpClientSpan.ktis gone, its helper is now private insideexecuteToolSpan.kt.closes: KG-808