Skip to content

Migrate GoogleClient to KoogHttpClient#1150

Merged
tiginamaria merged 11 commits intodevelopfrom
tigina/koog-http-google
Nov 24, 2025
Merged

Migrate GoogleClient to KoogHttpClient#1150
tiginamaria merged 11 commits intodevelopfrom
tigina/koog-http-google

Conversation

@tiginamaria
Copy link
Copy Markdown
Collaborator

@tiginamaria tiginamaria commented Nov 19, 2025

  • Migrate GoogleClient to KoogHttpClient to provide en ability to use ti with java-specific clients
  • Add parameters support to requests in KoogHttpClient

Motivation and Context

  • Add parameters to

Breaking Changes


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 19, 2025

Qodana for JVM

1131 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 1120
Missing KDoc for public API declaration 🔶 Warning 11
@@ Code coverage @@
+ 72% total lines covered
16624 lines analyzed, 12057 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Copy Markdown
Contributor

@kpavlov kpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tiginamaria
Looks good in general, but let's make parameters non-nullable.

@kpavlov kpavlov self-requested a review November 20, 2025 13:08
@kpavlov kpavlov added the refactoring Code improvements that enhance structure, readability, and quality without changing functionality label Nov 21, 2025
@tiginamaria tiginamaria force-pushed the tigina/koog-http-google branch 2 times, most recently from 2a1ecbf to e0efd71 Compare November 24, 2025 12:40
@tiginamaria tiginamaria force-pushed the tigina/koog-http-google branch from 230670c to 207def0 Compare November 24, 2025 15:09
@tiginamaria tiginamaria merged commit 4a4302b into develop Nov 24, 2025
10 checks passed
@tiginamaria tiginamaria deleted the tigina/koog-http-google branch November 24, 2025 16:58
kpavlov pushed a commit that referenced this pull request Dec 5, 2025
* Migrate `GoogleClient` to `KoogHttpClient` to provide en ability to
use to with java-specific clients
* Add parameters support to requests in `KoogHttpClient`
vova-jb pushed a commit that referenced this pull request Jan 27, 2026
* Migrate `GoogleClient` to `KoogHttpClient` to provide en ability to
use to with java-specific clients
* Add parameters support to requests in `KoogHttpClient`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Code improvements that enhance structure, readability, and quality without changing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants