Skip to content

Fix: [KTOR-8881] Fix the issue with reading the configuration file.#1122

Closed
TuAbE wants to merge 2 commits intoJetBrains:developfrom
TuAbE:develop-tabue
Closed

Fix: [KTOR-8881] Fix the issue with reading the configuration file.#1122
TuAbE wants to merge 2 commits intoJetBrains:developfrom
TuAbE:develop-tabue

Conversation

@TuAbE
Copy link
Copy Markdown

@TuAbE TuAbE commented Nov 14, 2025

[KTOR-8881] Determine whether the timeout is configured in application.yaml; if it is, read the configuration instead of exiting directly.(#807 OR #906)

When a timeout is defined for any LLM provider in application.yaml, use that value instead of the built-in default.

Motivation and Context

Previously the application silently ignored per-provider timeout values that were declared in application.yaml; it always fell back to the hard-coded default.

Whenever a timeout entry exists under an LLM provider in application.yaml, that value is now honoured, so operators can tune timeouts without touching code or rebuilding the artifact.

Breaking Changes

No breaking changes.

If timeout is absent from application.yaml the service behaves exactly as before (uses the built-in default).

Only users who already declared timeout but assumed it was inactive will notice the difference—those entries will now take effect, which is the intended behaviour.


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

…n.yaml; if it is, read the configuration instead of exiting directly.(JetBrains#807 OR JetBrains#906)
@TuAbE TuAbE marked this pull request as ready for review November 14, 2025 13:44
@TuAbE TuAbE marked this pull request as draft November 14, 2025 13:44
@TuAbE TuAbE marked this pull request as ready for review November 14, 2025 13:46
@nomisRev nomisRev requested a review from Rizzen November 25, 2025 08:58
@aozherelyeva
Copy link
Copy Markdown
Contributor

Hi @TuAbE, could you please rebase the branch onto the freshest develop? I think we're good to go right after it!

@aozherelyeva
Copy link
Copy Markdown
Contributor

Ah, I see, the fix is already in develop. Closing the PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants