fix: show Connect buttons for unconfigured SSO providers when another provider is already configured#5932
Conversation
… provider is already configured Previously, once any SSO provider (e.g. SAML) was configured, the 'Connect an Identity Provider' section was completely hidden. This made it impossible to add a second provider (e.g. OIDC) through the UI. Now both configured provider management sections AND Connect buttons for unconfigured providers are shown simultaneously. Co-Authored-By: ashwin <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile SummaryThis PR fixes a UI bug in Confidence Score: 5/5Safe to merge — purely a frontend UI restructure with no logic errors or security implications. The change is a straightforward UI fix that correctly separates two independent render blocks. No API calls, permissions, or data mutations are modified. Early return ordering is correct (loading check before admin-disabled check). The modals (SSOModal, OIDCModal, LDAPModal with hideDelete) are appropriately scoped to the Connect section only, consistent with prior behavior. No P0 or P1 findings. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix: show Connect buttons for unconfigur..." | Re-trigger Greptile |
Co-Authored-By: ashwin <[email protected]>
Test Results: SSO Provider Visibility FixRan the frontend locally against a local dev environment. Used Playwright CDP to intercept API responses and simulate configured SSO providers (since the Free plan doesn't include SSO features). Results
|
Context
When any SSO provider (e.g., SAML) was configured, the "Connect an Identity Provider" section was completely hidden. This was caused by a mutually exclusive ternary in
OrgSsoTab— it either showed the "Connect" buttons OR the configured provider management sections, never both. This made it impossible to add a second provider (e.g., OIDC) through the UI once any provider was already set up.The fix changes the rendering to show both sections independently:
Steps to verify the change
Type
Checklist
type(scope): short descriptionLink to Devin session: https://app.devin.ai/sessions/de20f37b99b744e4af697e919eb017aa