Skip to content

Drop superfluous cmake modules#10403

Merged
yhabteab merged 1 commit intomasterfrom
drop-superfluous-cmake-modules
Apr 8, 2025
Merged

Drop superfluous cmake modules#10403
yhabteab merged 1 commit intomasterfrom
drop-superfluous-cmake-modules

Conversation

@yhabteab
Copy link
Copy Markdown
Member

@yhabteab yhabteab commented Apr 3, 2025

These modules are already provided by CMake itself, so we don't need to ship them by ourselves.

PS: Let's see whether the GAs have something to say about this :).

@cla-bot cla-bot Bot added the cla/signed label Apr 3, 2025
@Al2Klimov
Copy link
Copy Markdown
Member

Al2Klimov commented Apr 3, 2025

TODO

@yhabteab
Copy link
Copy Markdown
Member Author

yhabteab commented Apr 4, 2025

Starting with PostgreSQL 9.3, Debian started 1 to split the PostgreSQL header files including the pg_type.h file into a separate package, which the FindPostgreSQL cmake module 2 requires. However, I'm not sure which CMake version introduced it but they accidentally added the PostgreSQL_TYPE_INCLUDE_DIR to the required variables and got fixed later with CMake 3.20. Though, on Debian 11 CMake version 3.18 and on Ubuntu CMake 3.16.3 are installed and contain that accidentally introduced bug, that's why the GHAs are failing. So, we'll have to ship the FindPostgreSQL module for a bit till these OSs get dropped.

Footnotes

  1. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=314427

  2. https://github.com/Kitware/CMake/blob/master/Modules/FindPostgreSQL.cmake#L157

These modules are already provided by CMake itself, so we don't need to
ship them by ourselves.
@yhabteab yhabteab force-pushed the drop-superfluous-cmake-modules branch from cc178ba to 5a30554 Compare April 7, 2025 08:27
Copy link
Copy Markdown
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for GHA = ok for me

@yhabteab yhabteab added the core/quality Improve code, libraries, algorithms, inline docs label Apr 7, 2025
@yhabteab yhabteab added this to the 2.15.0 milestone Apr 7, 2025
@yhabteab yhabteab enabled auto-merge April 7, 2025 15:44
@yhabteab yhabteab merged commit cfca890 into master Apr 8, 2025
28 of 30 checks passed
@yhabteab yhabteab deleted the drop-superfluous-cmake-modules branch April 8, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed core/quality Improve code, libraries, algorithms, inline docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants