🐛 Fix ZeroDivisionError in test_time_overhead_on_handlers_of_auth_decorators#9046
Closed
GitHK wants to merge 1 commit intoITISFoundation:masterfrom
Closed
🐛 Fix ZeroDivisionError in test_time_overhead_on_handlers_of_auth_decorators#9046GitHK wants to merge 1 commit intoITISFoundation:masterfrom
test_time_overhead_on_handlers_of_auth_decorators#9046GitHK wants to merge 1 commit intoITISFoundation:masterfrom
Conversation
GitHK
requested review from
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
|
Contributor
Author
|
@Mergifyio queue |
giancarloromeo
approved these changes
Apr 21, 2026
Contributor
Merge Queue Status
Waiting for:
All conditions
|
matusdrobuliak66
approved these changes
Apr 21, 2026
pcrespov
reviewed
Apr 21, 2026
| ref_elapsed_ns = statistics.median(public_elapsed_times) | ||
| elapsed_ns = statistics.median(admin_elapsed_times) | ||
| elapsed_ratio = elapsed_ns / max(ref_elapsed_ns, 1) | ||
| elapsed_ratio = elapsed_ns / max(ref_elapsed_ns, sys.float_info.min) |
Member
There was a problem hiding this comment.
Why would denominator max(ref_elapsed_ns, 1) produce a division by zero?
if ref_elapsed_ns==0 then max(ref_elapsed_ns, 1) == 1 and elapsed_ns / max(ref_elapsed_ns, 1) = elapsed_ns
In the description you mention that it has to do with 1 being integer... but i od not undrstand it. You mean it has to be ``max(ref_elapsed_ns, 1.0)`
Member
There was a problem hiding this comment.
Thisi s a bit strange ...
It seems to me that the code tested is not the same as the one you modify here. In the snapshot below (from the CI ) i do not see the line elapsed_ratio = elapsed_ns / max(ref_elapsed_ns, 1) ...
what am i missing here?
Contributor
Author
There was a problem hiding this comment.
You are correct, this was coming form the hot fix branch which does not have this fix implemented. Closing PR since it's useless.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9046 +/- ##
==========================================
- Coverage 87.35% 82.77% -4.58%
==========================================
Files 2056 792 -1264
Lines 81003 37011 -43992
Branches 1451 182 -1269
==========================================
- Hits 70758 30636 -40122
+ Misses 9834 6325 -3509
+ Partials 411 50 -361
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
did not properly check, already fixed, the Hotfix branch was casing issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes a flaky
ZeroDivisionErrorintest_time_overhead_on_handlers_of_auth_decoratorsthat occurs whenref_elapsed_ns(the median of public endpoint timings) resolves to 0.The previous guard
max(ref_elapsed_ns, 1)used an integer floor of 1, which does not protect against a float 0.0 fromstatistics.median. Replaced withmax(ref_elapsed_ns, sys.float_info.min)(~2.2e-308), the smallest positive normalized float, guaranteeing the denominator is never zero.Related issue/s
How to test
Dev-ops