Skip to content

🐛 [Frontend] Redesign Logger log renderer#9044

Merged
odeimaiz merged 18 commits intoITISFoundation:masterfrom
odeimaiz:fix/prj-conversation
Apr 20, 2026
Merged

🐛 [Frontend] Redesign Logger log renderer#9044
odeimaiz merged 18 commits intoITISFoundation:masterfrom
odeimaiz:fix/prj-conversation

Conversation

@odeimaiz
Copy link
Copy Markdown
Member

@odeimaiz odeimaiz commented Apr 20, 2026

What do these changes do?

There were a couple of issues with the old rowrenderer in the logger: the last row would not be properly rendered and it wasn't very aesthetic.

This PR brings a new log rendererer, when clicking on a log row opens a popup widget showing: the full message, log level badge, timestamp, node, copy-to-clipboard button, and close button.

Bonus:

  • Fixes the user 🔔 Notified widget in the project conversations (reported by @matusdrobuliak66 )
LogViewer

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Apr 20, 2026
@odeimaiz odeimaiz added this to the Etna milestone Apr 20, 2026
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Apr 20, 2026
@odeimaiz odeimaiz requested a review from Copilot April 20, 2026 08:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the “project conversations” notification rendering by using the canonical message-ownership helper from the Message model, aligning NotificationUI behavior with the rest of the conversation UI.

Changes:

  • Replace the (non-existent) MessageUI.isMyMessage(...) call with osparc.data.model.Message.isMyMessage(...) in NotificationUI.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

@odeimaiz odeimaiz changed the title 🐛 [Frontend] Fix: Project conversations 🐛 [Frontend] Redesign Logger log renderer Apr 20, 2026
@odeimaiz odeimaiz enabled auto-merge (squash) April 20, 2026 13:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Comment thread services/static-webserver/client/source/class/osparc/widget/logger/LoggerModel.js Outdated
@sonarqubecloud
Copy link
Copy Markdown

@odeimaiz odeimaiz merged commit 19ad461 into ITISFoundation:master Apr 20, 2026
108 of 110 checks passed
@odeimaiz odeimaiz deleted the fix/prj-conversation branch April 20, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants