Skip to content

🐛 fix(storage): handle directory-level paths in delete_paths celery task#9038

Draft
giancarloromeo wants to merge 2 commits intoITISFoundation:masterfrom
giancarloromeo:fix/storage-delete-paths-directory-level-validation
Draft

🐛 fix(storage): handle directory-level paths in delete_paths celery task#9038
giancarloromeo wants to merge 2 commits intoITISFoundation:masterfrom
giancarloromeo:fix/storage-delete-paths-directory-level-validation

Conversation

@giancarloromeo
Copy link
Copy Markdown
Contributor

@giancarloromeo giancarloromeo commented Apr 17, 2026

What do these changes do?

This pull request enhances the delete_paths functionality to support deletion of entire node-level directories (i.e., paths like project_id/node_id), not just individual files.

Related issue/s

How to test

cd services/storage
make install-dev
pytest -vv --pdb tests/unit/test_async_jobs_handlers_paths.py::test_delete_paths_with_node_level_directory

Dev-ops

No changes.

@giancarloromeo giancarloromeo self-assigned this Apr 17, 2026
@giancarloromeo giancarloromeo added the a:storage issue related to storage service label Apr 17, 2026
@giancarloromeo giancarloromeo added this to the Etna milestone Apr 17, 2026
@giancarloromeo giancarloromeo changed the title 🐛 fix(storage): handle directory-level paths in delete_paths celery task 🐛 fix(storage): handle directory-level paths in delete_paths celery task Apr 17, 2026
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.79%. Comparing base (16dd1a9) to head (183622b).

❗ There is a different number of reports uploaded between BASE (16dd1a9) and HEAD (183622b). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (16dd1a9) HEAD (183622b)
unittests 32 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9038       +/-   ##
===========================================
- Coverage   87.35%   66.79%   -20.56%     
===========================================
  Files        2056      844     -1212     
  Lines       80971    39495    -41476     
  Branches     1451      182     -1269     
===========================================
- Hits        70731    26381    -44350     
- Misses       9829    13063     +3234     
+ Partials      411       51      -360     
Flag Coverage Δ
integrationtests 63.92% <ø> (+0.02%) ⬆️
unittests 87.03% <85.71%> (+0.80%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 69.29% <ø> (-16.66%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.76% <ø> (-12.85%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 73.91% <ø> (-13.59%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 87.03% <85.71%> (+0.17%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.22% <ø> (-27.54%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dd1a9...183622b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:storage issue related to storage service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error when deleting project(s)

1 participant