🐛 fix(storage): handle directory-level paths in delete_paths celery task#9038
Draft
giancarloromeo wants to merge 2 commits intoITISFoundation:masterfrom
Draft
Conversation
delete_paths celery task
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9038 +/- ##
===========================================
- Coverage 87.35% 66.79% -20.56%
===========================================
Files 2056 844 -1212
Lines 80971 39495 -41476
Branches 1451 182 -1269
===========================================
- Hits 70731 26381 -44350
- Misses 9829 13063 +3234
+ Partials 411 51 -360
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What do these changes do?
This pull request enhances the
delete_pathsfunctionality to support deletion of entire node-level directories (i.e., paths likeproject_id/node_id), not just individual files.Related issue/s
How to test
cd services/storage make install-dev pytest -vv --pdb tests/unit/test_async_jobs_handlers_paths.py::test_delete_paths_with_node_level_directoryDev-ops
No changes.